This repository was archived by the owner on Dec 8, 2023. It is now read-only.
feat: airflow modern syntax migration#35
Merged
morgante merged 4 commits intogetgrit:mainfrom Oct 24, 2023
Merged
Conversation
morgante
reviewed
Oct 24, 2023
| $call <: collect_kwargs($kwargs), | ||
| $decorator_args = join(list=$kwargs, separator=", "), | ||
| $task_func => `@task($decorator_args)\n$task_func`, | ||
| // $call => $name |
Contributor
There was a problem hiding this comment.
No commented out code please.
morgante
reviewed
Oct 24, 2023
| $function <: dag_definition($var) as $decl, | ||
| $dag_refs = [], | ||
| $function <: contains bubble ($function, $dag_refs) identifier() as $dag_ref where { | ||
| $dag_ref <: after $decl, |
Contributor
There was a problem hiding this comment.
What's this line meant to do? $decl is unbound, so this doesn't really check anything.
Contributor
Author
There was a problem hiding this comment.
Whoops, I realized this pattern wasn't used.
it's from an older impl that I got rid of.
Removed it.
morgante
approved these changes
Oct 24, 2023
Contributor
morgante
left a comment
morgante
left a comment
There was a problem hiding this comment.
Looks good to start. I will need to do some more testing to validate it works successfully on real repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A migration that moves airflow legacy syntax to the newer decorator syntax.
/claim #31