HOMEPAGE_ALLOWED_HOSTS: Failed host validation emits HTTP 200

[belthesar]

Description

Hi folks -

Congrats on your 1.0 release! 🎉 I just updated myself, and was surprised to see the host validation failure message. When I looked to see why I didn't get an alert on the deploy, I was surprised to see that the error message when viewing the page was accompanied by an HTTP 200.

This type of error I would expect to throw a 403 or maybe a 500, and either would have caused the healthcheck I configured to throw an error and send me an alert.

This isn't a huge deal, but it would be better to return an HTTP status code >299, dealer's choice, to allow for monitoring systems to appropriately detect the issue and surface it.

Thanks!

homepage version

v1.0.4

Installation method

Docker

Configuration

No response

Container Logs

No response

Browser Logs

No response

Troubleshooting

With a misconfigured HOMEPAGE_ALLOWED_HOSTS environment variable, check the HTTP status code returned by Homepage when accessing the page.

[github-actions[bot]]

This discussion has been automatically closed due to inactivity. See our contributing guidelines for more details.

[github-actions[bot]]

This discussion has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.