Setting: maxBookmarkGroupColumns is not working properly

[onokje]

Description

I have tried to use the maxBookmarkGroupColumns setting, but it seems to have several problems:

• it only applies to very large screen sizes (3xl)
• The minimum number of columns seems to be 6 (why?)

homepage version

1.4.6

Installation method

Docker

Configuration

maxBookmarkGroupColumns: 4

Container Logs

No response

Browser Logs

No response

Troubleshooting

Add maxBookmarkGroupColumns: 4 to settings.yaml

Make 5 or more bookmark groups
I expect a wrap after the 4th group, but it doesn't happen.

If I change the value to 8, I can see that a css class is added to bookmark groups: "3xl:basis-1/8".
I looked into the code a bit: It seems this class is only added when the value is 6 or higher, and it also does not add different classes for smaller screen sizes (for example I run at 1920x1080 and 3xl: does not seem to apply then)

[jm-hill]

This setting is also not working for me.

[My-Random-Thoughts]

Ditto, not working at all. More info to test:

I have the following set in my settings.xml file:

---
fullWidth: false
maxBookmarkGroupColumns: 3
layout:
    A:
        tab: Testing
        style: column
    B:
        tab: Testing
        style: column
    C:
        tab: Testing
        style: column
    D:
        tab: Testing
        style: column
    E:
        tab: Testing
        style: column
    F:
        tab: Testing
        style: column
    G:
        tab: Testing
        style: column
    H:
        tab: Testing
        style: column
    I:
        tab: Testing
        style: column
    J:
        tab: Testing
        style: column

And in my bookmarks.xml:

---
- A:
    - A1:
        - description: "A1"
    - A2:
        - description: "A2"
- B:
    - B1:
        - description: "B1"
    - B2:
        - description: "B2"
- C:
    - C1:
        - description: "C1"
    - C2:
        - description: "C2"
- D:
    - D1:
        - description: "D1"
    - D2:
        - description: "D2"
- E:
    - E1:
        - description: "E1"
    - E2:
        - description: "E2"
- F:
    - F1:
        - description: "F1"
    - F2:
        - description: "F2"
- G:
    - G1:
        - description: "G1"
    - G2:
        - description: "G2"
- H:
    - H1:
        - description: "H1"
    - H2:
        - description: "H2"
- I:
    - I1:
        - description: "I1"
    - I2:
        - description: "I2"
- J:
    - J1:
        - description: "J1"
    - J2:
        - description: "J2"

I would expect the A..J to be split into

A B C
D E F
G H I
J

but instead it's

A B C D E F
G H I J

Setting maxBookmarkGroupColumns to any number makes no difference.

[My-Random-Thoughts]

@shamoon can you take a look at this bug please, it's quite annoying.

[shamoon]

This setting was originally intended to allow additional bookmark columns on very large screens, not to reduce the normal maximum. Bookmark groups already use up to 6 columns, so values of 6 or lower dnot change the layout (in other words only 7 or 8 do anything). I can see how the name makes the expected behavior understandable, and the documentation could be clearer.

We’ll consider expanding the setting in the future so it can also limit the number of columns but the behavior above is currently expected, so not a bug.

[shamoon]

Ps. this is pretty trivial to do with custom css, something like:

  .bookmark-group {
    flex-basis: 33.333333% !important;
  }