not just fullscreen

[tcurdt]

it would be super helpful if I could pick a window instead of a full screen and only share that window.

[iparaskev]

I hear this. I will have a look during the weekend on how we can integrate this without complicating the codebase too much. I am happy to help also if you want to contribute it yourself.

[tcurdt]

I can't think of a way to do this without knowing the window position. #362 seems to do this which means we have a starting point. If we have the location then we can reuse our overlay surface and we do not need to do anything os specific.

AFAIK clicks are usually in screen positions and later they get translated to the window origin to find the UI elements.
One way could be to have the OS offset the coordinates to the window origin and send those. This seems the most simple and efficient to me. That would eliminate the need for any window tracking. The window just becomes the new origin.

I like this direction. I would still like the visual feedback on what the user is clicking. We could have a button on the top right which could change the selection from screen to window. And then a bounding box will be drawn on each window the cursor is pointing to.

Indeed. I also had something like that in mind.
The shift-click was just for the POC.

[iparaskev]

One way could be to have the OS offset the coordinates to the window origin

Yes this is what I meant with tracking the window. Actually it was much simpler as we already had this information on the capture callback. The feature is almost ready in #363. There are still some bugs I want to fix and test it a bit more. I will make a pre-release tomorrow for you to try if you want.

[iparaskev]

Pre-release has been published. If you end up trying it and find any bugs/want improvements, feel free to comment here or in the PR.

[tcurdt]

Seems to work surprisingly well. 👍

[iparaskev]

Awesome, thanks for testing it. I just pushed the final touches (it took me some time to properly implement control of a window even when it is behind another one, I had to make the remote control events to be window specific). We will pair with Costa during the weekend to test it a bit more and probably we will release it on Sunday.

[anatoliy-t7]

#362

[iparaskev]

Thanks for the PR. I think it is a good starting point but it is full of bugs.

• First of all the content selection shouldn't be done via thumbnails. See my comment above.
• It broke the markers for when a screen is being shared.
• Drawing/pointing is not being translated properly when a window is being shared.
• In the controller's view when the window is being resized we get black pixels.
• If the window is moved to another screen the borders do not move with it.

I haven't looked at the code a lot, because of the content picking logic which has done many unnecessary changes. Also I do not think the linking change in build.rs is really needed (as long as CI is working, this is a local issue in your machine).

I am going to be honest here with the danger of being rude to first time contributors. If you actually want to work on this I am happy to review everything and find the way to do this. If your plan is to just use AI, I think it will take less of my time for me to implement this. If you don't want (or don't have the time) I am happy to repurpose the PR only for the capturing changes and remove the content picking logic.

[anatoliy-t7]

@iparaskev
Sorry to take your time. PR was just to show that it is possible to build this feature with AI.
Please use PR how you need. I will be happy if PR just helps you to make this feature implemented.

[iparaskev]

No worries. And I will definitely use things from the PR. I think it is doable to have this implemented soon.

PS: I am not anti-AI, I also use it for every change I am commiting, I just want to keep the codebase maintainable by controlling the abstractions and keeping the changes minimal.

[iparaskev]

#363 has been merged. Thanks for the discussion, actual user feedback is the way to make this the best screen-sharing tool for devs. If you find any bugs @tcurdt @anatoliy-t7 please report them. Also I've changed the codec to use h265 (which means better image quality and less bandwidth). If you know anyone who would benefit from using Hopp feel free to share the project with them.