-
Notifications
You must be signed in to change notification settings - Fork 55
Open
Description
Confirm how continue on error works with ignore lists and metadata and non left joins.
We want to confirm the following scenarios and update docs code appropriately
I will refer to
- continue one error as coe
- metadata as md
- when !coe && !md and there is no match : With the retry code change, this will now fail , but should produce no row, if we do not do this there is no difference between a join and a left join.
- when !coe && !md and there is no match, with ignore code should not produce a row
- if we ignore 404 and have md with !coe
- if we ignore 404 and have md with coe, should give the same results as 3)
- Ignore parse errors = true gives us an empty payload. Related to 3) should we return MD if configured or an empty collection (ie. the non LEFT join case)
**Design decisions to make **
- to resolve 3 and 4 we need; if there is MD should it be put out in the ignore case.
- do we need an ignoreExceptions so we can get back to pre retry behaviour if wanted.
Current Thinking :
- if there is no metadata defined then ignore return an empty collection, with and without coe
- if there is a metadata and we have ignore then we will return a filled in row with the metadata , we will need a new completion code enum value to indicate this was due to an ignore.
- ignore parse errors means we get nothing back from the deserialization, in this case if there is no metadata with and without coe
- to be consistent then we could have a succeeded with ignore parse error completion code. Maybe this is not needed.
Metadata
Metadata
Assignees
Labels
No labels