chore(linting): Improve Rubocop consistency#287
Merged
Merged
Conversation
julienbourdeau
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The library currently does not depends on Rails so it doesn't make sense to rely on
rubocop-railsas it could lead to invalid correction by Rubocop. For instance, it would try to fixTime.nowbyTime.zone.nowwhich is not available.Also, we expect this client to work with Ruby 3.1 but the Rubocop configuration actually had not
TargetRubyVersionset which could lead to code working locally but breaking on the CI.Description
This removes
rubocop-railsand setTargetRubyVersionto 3.1.