Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for filtering transports based on whether they support streaming, enabling the system to skip non-streamable transports when handling streaming requests (e.g., Server-Sent Events).
Changes:
- Added
IsStreamable()method to theTransportinterface to indicate streaming support capability - Modified transport filtering logic in
RoundTripto skip non-streamable transports when the Accept header indicates a streaming request - Updated all transport initialization calls to include the new
isStreamableparameter (AMP cache set to false, all others set to true)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| race_transport.go | Added streaming header detection and transport filtering logic; imported log/slog |
| kindling.go | Extended Transport interface with IsStreamable method; updated namedTransport struct and all newTransport calls with isStreamable parameter |
| kindling_test.go | Updated test transport initialization calls to include the new isStreamable parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
myleshorton
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.