Fix SSH hanging on nohup background processes#122
Merged
myleshorton merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
SSH waits for all file descriptors to close before disconnecting. The nohup'd background processes inherited stdin from the SSH session, keeping the connection alive indefinitely. Adding < /dev/null closes stdin so SSH can disconnect immediately after launching processes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the e2e GitHub Actions deploy workflow to prevent SSH sessions from hanging after launching background services via nohup ... & by explicitly closing stdin for those processes.
Changes:
- Add
< /dev/nullto the remotenohup python3 -m http.server ... &invocation. - Add
< /dev/nullto each remotenohup /root/lantern-box run ... &invocation and document the reason inline.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nohup ... &inherits stdin from the SSH session, keeping the connection open indefinitely< /dev/nullto all nohup commands so SSH can disconnect immediatelyTest plan
gh workflow run e2e.yaml🤖 Generated with Claude Code