Skip to content

adding WATER detour option for downloading and seeding#187

Merged
WendelHime merged 5 commits intomainfrom
feat/using-radiance-kindling-http-client
Mar 18, 2026
Merged

adding WATER detour option for downloading and seeding#187
WendelHime merged 5 commits intomainfrom
feat/using-radiance-kindling-http-client

Conversation

@WendelHime
Copy link
Copy Markdown
Contributor

@WendelHime WendelHime commented Mar 17, 2026

This PR:

  • use the latest lantern-water changes that support a http client for magnet downloader and seeder
  • add detour option for using another outbound for downloading and seeding the WASM file

Copilot AI review requested due to automatic review settings March 17, 2026 14:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the WATER outbound’s WASM download + seeding pipeline to use the latest lantern-water APIs and to route HTTP traffic through the Radiance Kindling HTTP client stack.

Changes:

  • Update lantern-water dependency to a newer revision that supports injecting an *http.Client for WASM downloading and seeding.
  • Introduce a shared http.Client in the WATER outbound, optionally sourcing its transport from radiance/kindling.
  • Update Go module dependencies (go.mod/go.sum) to include github.com/getlantern/radiance and related transitive upgrades.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
protocol/water/outbound.go Creates a shared HTTP client (optionally Kindling-backed) and passes it into the WASM downloader and seeder.
go.mod Bumps lantern-water and adds getlantern/radiance plus refreshed indirect dependencies.
go.sum Reflects the updated dependency graph for the new module versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@garmr-ulfr
Copy link
Copy Markdown
Collaborator

  • it also imports radiance kindling HTTP client and uses it for downloading WASM files and seeding

Since radiance depends on lantern-box, lantern-box shouldn't also depend on radiance. Introducing that circular dependency makes it very fragile—changes to radiance now have the potential to break a dependency, or lantern-box would have to use an older version. This makes it very difficult to maintain.

The detour option will be used for using another outbound to download and seed the WASM file
@WendelHime WendelHime changed the title using radiance kindling http client adding detour option for downloading and seeding Mar 17, 2026
@WendelHime WendelHime changed the title adding detour option for downloading and seeding adding WATER detour option for downloading and seeding Mar 17, 2026
Copy link
Copy Markdown
Collaborator

@garmr-ulfr garmr-ulfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just the one comment.

@WendelHime WendelHime merged commit 3a53f3a into main Mar 18, 2026
3 checks passed
@WendelHime WendelHime deleted the feat/using-radiance-kindling-http-client branch March 18, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants