Open
Conversation
- Rewrote README-dev.md to fix outdated versions, missing steps, and ambiguous instructions (flutter pub get, xcodebuild -runFirstLaunch, gomobile via make targets, Java prereq, NDK env vars) - Corrected Android NDK version (23.x -> 27.0.12077973) and CMake version (3.18.1 -> 3.22.1) to match CI - Added ANDROID_NDK_VERSION, ANDROID_CMAKE_VERSION, ANDROID_BUILD_TOOLS_VERSION, and ANDROID_PLATFORM variables to Makefile as the single source of truth for SDK component versions - Added install-android-sdk Makefile target that runs sdkmanager with the correct versions and auto-accepts licenses Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…K tip Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rdcoding Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jigar-f
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates contributor-facing developer documentation and centralizes Android SDK component versioning in the Makefile to reduce setup drift vs CI.
Changes:
- Rewrites
README-dev.mdwith clearer prerequisites, platform setup steps, and build/run guidance. - Adds Android SDK version variables and a new
install-android-sdkMakefile target to install consistent SDK components.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| README-dev.md | Major rewrite of dev docs, including prerequisites and platform build/run instructions. |
| Makefile | Adds Android SDK component version vars + install-android-sdk target. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README-dev.mdto fix outdated information, missing prerequisites, and ambiguous instructions that were causing build failures for new contributors.install-android-sdkMakefile target as a single source of truth for Android SDK component versions, replacing the stale hardcoded versions in the old READMEChanges
README-dev.mdflutter pub get, which must be run after cloning and after dependency changesxcodebuild -runFirstLaunchone-time setup step; replaced manual gomobile commands withmake install-macos-deps/make install-gomobile23.x→27.0.12077973) and CMake version (3.18.1→3.22.1) to match CI; added Java 17+ prerequisite; added NDK environment variable instructions; replaced rawsdkmanagerinvocation withmake install-android-sdkgo install/gomobile initcommands withmake install-ios-depsMakefileANDROID_NDK_VERSION,ANDROID_CMAKE_VERSION,ANDROID_BUILD_TOOLS_VERSION, andANDROID_PLATFORMvariablesinstall-android-sdktarget that runssdkmanagerwith the correct versions and auto-accepts licensesTest plan
make install-android-sdkinstalls the correct SDK components on a clean Android setupmake android-debugproduces a valid APK after following the updated instructions end-to-endmake macosbuilds successfully aftermake install-gomobileon a clean macOS setup🤖 Generated with Claude Code