android: detach connect() scope so withTimeout actually unblocks the UI

[myleshorton]

Follow-up to #8688 (which was merged to main and has since landed on garmr/radiance-daemon-refactor via the main-merge, making the cherry-pick commits this PR originally carried redundant — those were dropped during rebase).

Problem

#8688's final shape wraps connect() in:

coroutineScope {
    val deferred = async(Dispatchers.IO) { connect() }
    try {
        withTimeout(VPN_START_TIMEOUT_MS) { deferred.await() }
    } catch (e: TimeoutCancellationException) {
        deferred.cancel()
        throw e
    }
}

Copilot correctly flagged that this still hangs in the exact scenario the timeout is meant to guard against. coroutineScope { } is a structured scope: when the block throws, it cancels its children and then waits for them to finish. deferred.cancel() only signals cancellation cooperatively, but connect() is a blocking JNI call with no suspension points — it ignores the signal. So coroutineScope blocks on the still-running child, the caller stays blocked, and the UI freezes just like before (Freshdesk #173507).

Fix

Switch to a detached CoroutineScope(SupervisorJob() + Dispatchers.IO). Its Job is not a child of the enclosing coroutine, so cancel() signals but doesn't join. The orphan coroutine keeps running the JNI call in the background until Go returns (or the process exits), but the caller is unblocked and runCatching.onFailure fires the ${errorCode}_timeout state for the UI.

Test plan

• Normal VPN start: timeout never fires, connect completes, status goes to Connected
• Simulated deadlock (e.g. time.Sleep(90 * time.Second) inside the Go /service/start handler): UI unfreezes after 60s with a *_timeout error instead of staying stuck
• Logs show VPN operation (...) timed out after 60000ms when the timeout fires

Related

• android: bound Mobile.startVPN with withTimeout(60s) #8688 (upstream fix on main — has the same issue; worth a follow-up PR against main)

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Cherry-picks Android service changes to add a wall-clock timeout around Go/JNI VPN start/connect calls, aiming to prevent UI freezes when Mobile.startVPN() / Mobile.connectToServer() deadlock.

Changes:

• Introduces a 60s VPN_START_TIMEOUT_MS ceiling for VPN start/connect operations.
• Wraps the blocking Go/JNI call in async + withTimeout { await() } and propagates timeout failures through the existing error path.
• Adds timeout-specific logging and errorCode suffixing (*_timeout) for clearer operator visibility.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.