android: harden detached connect timeout gate#8696
Merged
myleshorton merged 1 commit intofisk/port-timeout-fix-to-mainfrom Apr 23, 2026
Merged
android: harden detached connect timeout gate#8696myleshorton merged 1 commit intofisk/port-timeout-fix-to-mainfrom
myleshorton merged 1 commit intofisk/port-timeout-fix-to-mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens the Android VPN “detached connect” single-flight gate so it cannot remain stuck when a coroutine is cancelled before the async { ... } body begins executing, preventing subsequent connect attempts from being permanently rejected.
Changes:
- Move
connectInFlightreset logic from theasyncbody’sfinallyto theDeferredcompletion callback. - Ensure early cancellation (before coroutine start) still triggers gate reset via
invokeOnCompletion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
myleshorton
approved these changes
Apr 23, 2026
2 tasks
myleshorton
added a commit
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on the port-timeout fix by making sure early coroutine cancellation cannot leave the Android VPN connect single-flight gate stuck on