don't delete tags on failure#8810
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the release cleanup behavior in the GitHub Actions release workflow to avoid deleting git tags when deleting a draft release, aligning with the goal of preserving tags after failures.
Changes:
- Remove
--cleanup-tagfrom thegh release deletecommand in the “Delete draft release” step so release deletion no longer removes the underlying git tag.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Do we want to update the workflow to keep --cleanup-tag for test/nightly runs and omit it only for real failed release cleanup? |
Contributor
Author
@atavism, we do not create tags on draft releases (anymore), so there is no tag to cleanup there, and the existing release cleanup does the job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a tag on build failure can be confusing.
https://wdynhnkxvsdx.slack.com/archives/C04T8M4AB1Q/p1779494717571219?thread_ts=1779411374.549329&cid=C04T8M4AB1Q
Let's stop doing that.