Add OnConnectionChangeFunc to WASM UIImpl to fix compilation#331
Merged
myleshorton merged 3 commits intoadam/unbounded-widget-proxyfrom Feb 23, 2026
Merged
Add OnConnectionChangeFunc to WASM UIImpl to fix compilation#331myleshorton merged 3 commits intoadam/unbounded-widget-proxyfrom
myleshorton merged 3 commits intoadam/unbounded-widget-proxyfrom
Conversation
Co-authored-by: myleshorton <1143966+myleshorton@users.noreply.github.com>
Co-authored-by: myleshorton <1143966+myleshorton@users.noreply.github.com>
myleshorton
approved these changes
Feb 23, 2026
Copilot
AI
changed the title
[WIP] Update implementation based on feedback for OnConnectionChangeFunc
Add OnConnectionChangeFunc to WASM UIImpl to fix compilation
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
OnConnectionChangeFunccallback field was added to the non-WASMUIImplstruct but missing from the WASM version, causing compilation failures for WASM builds since both share the sameBroflakeOptionsstruct.Changes
OnConnectionChangeFuncfield to WASMUIImplstruct inui_wasm_impl.goOnConsumerConnectionChangemethod to invoke callback before firing JavaScript eventBoth implementations now have consistent callback support:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.