fix: what a day-one QA found on a fresh create-project - #109
Merged
Conversation
Four findings on a stock `composer create-project milpa/framework` app, each verified on fresh cattle (greenhouse evidence/0565): - `bin/mcp-server.php` lied: it sent the reader to `composer require milpa/tool-runtime milpa/mcp-server` (tool-runtime already ships) and to `coa agent:enable` (no such command). It now names the one command that switches the surface on: `capabilities:enable milpa/mcp-server`; its comment says which package is opt-in and which is not. - phpstan was red on install: config/operations.php pre-listed `DevToolsOperations`, a class this app does not ship. The skeleton now lists only what it ships; milpa/devtools 0.28 declares its provider in its manifest and `capabilities:enable milpa/devtools` writes it here (app-runtime's registerOperations). The header says so, in English. - HelloPlugin and OperationsHttpPlugin carried «Your Name» / example.com into `plugins:list`; they carry the skeleton's own identity, with the note to make it yours. - The README says what «OK, but some tests were skipped!» means on a fresh app: the skipped tests measure opt-in capabilities and each skip names its package. Tests: the two that expected `make` from the pre-listed class now measure the new rule — installed but not declared, absent (control); declared as the enable writes it, offered. CI opt-in: devtools >= 0.28.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four findings on a stock
create-projectapp, verified on fresh cattle (greenhouse evidence/0565):bin/mcp-server.phpsent the reader tocomposer require milpa/tool-runtime milpa/mcp-server(tool-runtime already ships) andcoa agent:enable(no such command). Now:capabilities:enable milpa/mcp-server.config/operations.phppre-listedDevToolsOperations. The skeleton lists only what it ships; milpa/devtools 0.28 declares its provider andcapabilities:enablewrites it.plugins:list→ the skeleton's own identity.Tests adapted to the declared-provider rule (control + measurement). CI opt-in devtools >= 0.28 (release in flight — rerun CI once it lands).