Dont repeat class names template arguements #448
Conversation
It prevents mistakes and it simplifies the readability of the code.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ZXShady, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to improve code readability and reduce verbosity in template class definitions by utilizing the injected class name feature in C++. This involves replacing explicit class names with template parameters in various member function signatures, such as constructors and assignment operators, across several core utility classes.
Highlights
- Code Style/Readability: Replaced explicit class names with template arguments (e.g.,
Box<T, C>) with the injected class name (Box) in constructors, assignment operators, and helper functions within several template classes. - Reduced Verbosity: The change leverages a C++ feature (injected class name) to make the code more concise and easier to read by avoiding repetition of the class name and its template parameters.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request systematically applies C++'s injected class name feature and, where applicable, relies on Class Template Argument Deduction (CTAD) to reduce verbosity in class template definitions. These changes span several header files (Binary.hpp, Box.hpp, Description.hpp, Field.hpp, Flatten.hpp, Tuple.hpp, Validator.hpp, Variant.hpp) and generally improve code readability and conciseness by removing redundant template arguments within class scopes.
The modifications are largely beneficial and align with modern C++ practices. One specific suggestion for Box.hpp has been provided to further enhance consistency with the PR's goals.
Minor typos were noted in the pull request title ("arguements" should be "arguments") and description ("ourseleves" should be "ourselves").
|
|
||
| /// Copy assignment operator if copyable | ||
| Box<T, C>& operator=(const Box<T>& other) requires (C == Copyability::COPYABLE) { | ||
| Box& operator=(const Box<T>& other) requires (C == Copyability::COPYABLE) { |
There was a problem hiding this comment.
The return type has been updated from Box<T, C>& to Box&, which is a good simplification using the injected class name.
However, the parameter type remains const Box<T>& other. For consistency with similar changes in this PR (e.g., the deleted assignment operator on line 76 which now uses const Box& _other) and the general goal of using the concise injected class name, consider changing this parameter to const Box& other.
Using Box<T> as a type for a parameter of Box<T, C> is unusual because Box is defined as template <class T, Copyability C>. const Box& would correctly resolve to const Box<T, C>& within this class context and align better with the PR's intent.
| Box& operator=(const Box<T>& other) requires (C == Copyability::COPYABLE) { | |
| Box& operator=(const Box& other) requires (C == Copyability::COPYABLE) { |
|
Merged, thanks |
2 participants
Repeating ourseleves provides no value and it is verbose