-
Notifications
You must be signed in to change notification settings - Fork 144
Split up the test pipeline for faster test runs #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @liuzicheng1987, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the build system's flexibility and efficiency, particularly for test and benchmark compilation. It introduces a consolidated CMake option for managing format-specific features and refines the dependency inclusion logic for JSON-related formats. Additionally, it optimizes benchmark build times by removing unnecessary precompiled headers, contributing to faster overall development cycles.
Highlights
- Build Configuration Simplification: Introduced a new CMake option,
REFLECTCPP_ALL_FORMATS, which allows for enabling or disabling all format-specific features (like AVRO, BSON, XML, etc.) with a single flag. This streamlines the build configuration process. - Dependency Management Refinement: Adjusted the CMake logic to ensure that the
jsonvcpkg feature and thesrc/reflectcpp_json.cppsource file are included not only whenREFLECTCPP_JSONis enabled, but also whenREFLECTCPP_AVRO,REFLECTCPP_CBOR, orREFLECTCPP_UBJSONare enabled. This suggests a shared underlying JSON parsing dependency for these formats. - Benchmark Build Optimization: Removed the
<gtest/gtest.h>header from the precompiled headers list in the CMake files for bothbenchmarks/allandbenchmarks/json. This optimization reduces compilation time for benchmarks, as testing framework headers are not typically needed for benchmark executables.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new CMake option REFLECTCPP_ALL_FORMATS to simplify enabling all serialization formats, which is useful for splitting CI/test pipelines. The changes also correctly identify that several other formats depend on the JSON implementation.
My review has identified a critical issue where these new dependencies are not correctly declared in the installed package configuration, which will break downstream projects. I've also provided a suggestion to improve the maintainability of the CMake scripts by avoiding duplicated logic. The other changes in benchmark configurations are correct cleanups.
No description provided.