Skip to content

Conversation

@aligirayhanozbay
Copy link
Contributor

I want to extend the jwt-cpp library so it has reflect-cpp compatibility. The interfaces exposed by reflect-cpp are already almost compatible with the traits expected by jwt-cpp, but a small addition to rfl::Object is needed so that it exposes a std::size_t count(const key_type& key) const method. This PR adds that methd.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @aligirayhanozbay, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the compatibility of the "reflect-cpp" library with the "jwt-cpp" library. The core change involves adding a specific method to "rfl::Object" that is required by "jwt-cpp"'s expected traits. This addition will allow for seamless integration between the two libraries, enabling "reflect-cpp" objects to be used directly with "jwt-cpp" functionalities.

Highlights

  • jwt-cpp Compatibility: Added a new method, "std::size_t count(const key_type& key) const noexcept", to the "rfl::Object" class in "include/rfl/Object.hpp". This method returns 1 if the key is found and 0 otherwise, fulfilling a requirement for "jwt-cpp"'s traits.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a count method to rfl::Object to improve compatibility with the jwt-cpp library. My review identifies a correctness issue with the implementation of this new method. It currently only checks for the existence of a key, rather than counting all occurrences, which is misleading for a container that supports duplicate keys. It also has an unintended side effect and an incorrect noexcept specifier. I've provided a suggestion for a more correct and robust implementation.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@liuzicheng1987
Copy link
Contributor

@aligirayhanozbay thanks for the contribution!

@liuzicheng1987 liuzicheng1987 merged commit ca53b22 into getml:main Aug 12, 2025
133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants