Skip to content

Better CSV example in README.md #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuzicheng1987 merged 1 commit into from
Sep 7, 2025
Merged

Better CSV example in README.md #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,17 @@ std::cout << "Hello, my name is " << homer2.first_name() << " "
reflect-cpp also supports tabular data formats, like CSV or Parquet:

```cpp
#include <rfl/csv.hpp>
#include <rfl/parquet.hpp>

struct Person {
std::string first_name;
std::string last_name = "Simpson";
std::string town = "Springfield";
int age;
rfl::Email email;
};
Comment on lines +255 to +261
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Person struct is missing the birthday field, but it's being used to initialize Person objects on lines 264-279. This will cause a compilation error. Based on other examples in this file and the CSV output, you should add a birthday field.

Suggested change
struct Person {
std::string first_name;
std::string last_name = "Simpson";
std::string town = "Springfield";
int age;
rfl::Email email;
};
struct Person {
std::string first_name;
std::string last_name = "Simpson";
std::string town = "Springfield";
rfl::Timestamp<"%Y-%m-%d"> birthday;
int age;
rfl::Email email;
};


const auto people =
std::vector<Person>({Person{.first_name = "Bart",
.birthday = "1987-04-19",
Expand All @@ -276,7 +285,7 @@ const auto bytestring = rfl::parquet::write(people);
This will resulting CSV will look like this:

```
"first_name";"last_name";"town";"birthday";"age";"email"
"first_name","last_name","town","birthday","age","email"
"Bart";"Simpson";"Springfield";1987-04-19;10;"bart@simpson.com"
"Lisa";"Simpson";"Springfield";1987-04-19;8;"lisa@simpson.com"
"Maggie";"Simpson";"Springfield";1987-04-19;0;"maggie@simpson.com"
Expand Down
Loading