Skip to content

Removed unnecessary std::move, fixes #533 #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuzicheng1987 merged 1 commit into from
Nov 4, 2025
Merged

Removed unnecessary std::move, fixes #533 #540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/rfl/parsing/to_single_error_message.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ inline std::string to_single_error_message(
std::optional<std::string> _msg_prefix = std::nullopt,
size_t _err_limit = 10) {
if (_errors.size() == 1) {
return std::move(_errors[0].what());
return _errors[0].what();
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

You are correct that std::move was unnecessary on the result of what(), as _errors[0].what() resolves to the const & overload, returning a const std::string&. Moving from a const reference results in a copy.

However, since _errors is passed by value, we can move from its elements. By moving from the Error object itself, you can invoke the &&-qualified overload of what(), which moves the string instead of copying it. This is more efficient.

Suggested change
return _errors[0].what();
return std::move(_errors[0]).what();

} else {
std::stringstream stream;
stream << (_msg_prefix
Expand Down
Loading