Skip to content

Redesign the way processors are identified; fixes #653#655

Merged
liuzicheng1987 merged 5 commits into
mainfrom
f/fix_processors
Apr 27, 2026
Merged

Redesign the way processors are identified; fixes #653#655
liuzicheng1987 merged 5 commits into
mainfrom
f/fix_processors

Conversation

@liuzicheng1987
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the library's processor logic by migrating static configuration flags from the Processors struct into standalone type traits within the rfl::internal namespace. This change affects multiple format parsers, including Avro, BSON, JSON, and Msgpack, which now utilize traits like no_field_names_v and default_if_missing_v. The review feedback identifies several issues in the newly added internal headers, such as missing includes for Processors.hpp, inconsistent namespace declarations, outdated header guards, and redundant forward declarations.

Comment thread include/rfl/internal/no_extra_fields_v.hpp Outdated
Comment thread include/rfl/internal/no_optionals_v.hpp Outdated
Comment thread include/rfl/internal/no_extra_fields_v.hpp Outdated
Comment thread include/rfl/internal/no_extra_fields_v.hpp Outdated
Comment thread include/rfl/internal/add_tags_to_variants_v.hpp
@liuzicheng1987 liuzicheng1987 merged commit 558acca into main Apr 27, 2026
537 of 566 checks passed
@liuzicheng1987 liuzicheng1987 deleted the f/fix_processors branch April 27, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant