Redesign the way processors are identified; fixes #653#655
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the library's processor logic by migrating static configuration flags from the Processors struct into standalone type traits within the rfl::internal namespace. This change affects multiple format parsers, including Avro, BSON, JSON, and Msgpack, which now utilize traits like no_field_names_v and default_if_missing_v. The review feedback identifies several issues in the newly added internal headers, such as missing includes for Processors.hpp, inconsistent namespace declarations, outdated header guards, and redundant forward declarations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.