Skip to content

Conversation

@zkarpinski
Copy link
Contributor

@zkarpinski zkarpinski commented Apr 9, 2025

@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.82%. Comparing base (fcb513c) to head (b73c55b).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
moto/s3/exceptions.py 75.00% 1 Missing ⚠️
moto/s3/models.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8785   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files        1266     1266           
  Lines      110646   110696   +50     
=======================================
+ Hits       102704   102752   +48     
- Misses       7942     7944    +2     
Flag Coverage Δ
servertests 28.08% <34.00%> (+<0.01%) ⬆️
unittests 92.79% <96.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zkarpinski zkarpinski changed the title [S3] inventory_configuration & storage_lens_configuration [S3] inventory_configuration support Apr 21, 2025
@zkarpinski zkarpinski marked this pull request as ready for review April 21, 2025 17:10
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for adding these features and for improving the scaffolding script @zkarpinski!

@bblommers bblommers added this to the 5.1.4 milestone Apr 27, 2025
@bblommers bblommers merged commit 3cde1c2 into getmoto:master Apr 27, 2025
57 checks passed
@bblommers bblommers modified the milestones: 5.1.4, 5.1.5 Apr 27, 2025
@zkarpinski zkarpinski deleted the s3-storage-lens branch April 28, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Scaffolding errors

2 participants