EC2: RunInstances must raise if default and request subnet is missing #8813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viren-nadkarni
force-pushed
the
ec2-default-subnets
branch
3 times, most recently
from
cb539c8 to
e67d4e0
Compare
viren-nadkarni
force-pushed
the
ec2-default-subnets
branch
from
e67d4e0 to
a6d4d46
Compare
viren-nadkarni
force-pushed
the
ec2-default-subnets
branch
from
684381a to
0914d44
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8813 +/- ##
==========================================
- Coverage 92.82% 92.82% -0.01%
==========================================
Files 1266 1266
Lines 110584 110665 +81
==========================================
+ Hits 102651 102720 +69
- Misses 7933 7945 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bblommers
approved these changes
Apr 27, 2025
Collaborator
bblommers
left a comment
bblommers
left a comment
There was a problem hiding this comment.
Great, thank you @viren-nadkarni!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AWS, EC2 RunInstances does not require a subnet ID. By default, it uses the default subnet from the default VPC. However, if the default subnet and VPCs are not available (i.e. if they were manually deleted), the subnet ID is mandatory.
This PR implements this behaviour in Moto.