Skip to content

Conversation

@Singha22
Copy link
Contributor

Resolves #8791

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 96.82540% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.82%. Comparing base (ec3224f) to head (e84c418).

Files with missing lines Patch % Lines
moto/timestreaminfluxdb/models.py 94.11% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #8814    +/-   ##
========================================
  Coverage   92.82%   92.82%            
========================================
  Files        1266     1266            
  Lines      110461   110586   +125     
========================================
+ Hits       102533   102654   +121     
- Misses       7928     7932     +4     
Flag Coverage Δ
servertests 28.08% <0.00%> (-0.04%) ⬇️
unittests 92.80% <96.82%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Singha22 Singha22 marked this pull request as ready for review April 17, 2025 15:45
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Singha22! Thanks for the PR - please see my comments

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for addressing the comments @Singha22!

@bblommers bblommers added this to the 5.1.4 milestone Apr 27, 2025
@bblommers bblommers merged commit 40de24e into getmoto:master Apr 27, 2025
53 of 55 checks passed
@bblommers bblommers modified the milestones: 5.1.4, 5.1.5 Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Timestream Influx DB] Parameter Group and Clusters

2 participants