-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
EC2: Implement CreateDefaultSubnet operation #8818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EC2: Implement CreateDefaultSubnet operation #8818
Conversation
95a7471 to
b3cf7ea
Compare
0fb6b62 to
bb8885e
Compare
b9c88de to
1149cbc
Compare
1149cbc to
f01d97b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8818 +/- ##
==========================================
+ Coverage 92.80% 92.82% +0.01%
==========================================
Files 1261 1266 +5
Lines 109888 110530 +642
==========================================
+ Hits 101986 102599 +613
- Misses 7902 7931 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bblommers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for improving the parity here @viren-nadkarni!
…efault_subnet' introduced by getmoto/moto#8818
This PR implements the EC2 CreateDefaultSubnet operation.
Moto already supports the EC2 CreateDefaultVpc and this is updated such that it also creates the default subnets.
The implementation assigns the
/20CIDR blocks to AZs in sequence as follows, but that's not always the case on AWS:172.31.0.0/20172.31.16.0/20172.31.32.0/20