This repository was archived by the owner on Oct 30, 2020. It is now read-only.
Retry failed submissions, possibily on a different queue#18
Merged
Conversation
a.k.a. dead-letter queue
However, it does not touch `max_retries` if explicitely set.
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=======================================
+ Coverage 93.15% 96.15% +3%
=======================================
Files 3 3
Lines 146 156 +10
Branches 20 21 +1
=======================================
+ Hits 136 150 +14
+ Misses 5 2 -3
+ Partials 5 4 -1
Continue to review full report at Codecov.
|
sbneto
approved these changes
Aug 14, 2018
Contributor
sbneto
left a comment
sbneto
left a comment
There was a problem hiding this comment.
- Minor rewriting
- Maybe some tests?
| try: | ||
| return func(*args, **kwargs) | ||
| except Exception as exc: | ||
| retry_kwargs = (metadata or {}).get('retry_kwargs', {}) |
Contributor
There was a problem hiding this comment.
Maybe metadata.get('retry_kwargs', {}) if metadata else {}?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a dead-letter queue to be set easily, for retries of failed submissions