Conversation
|
|
||
| ical.add_component(ie) | ||
|
|
||
| # If the directory for the ICS file don't exist, make it |
There was a problem hiding this comment.
Suggested fixes for comment: # If the directory for the ICS file doesn't exist, create it
|
Thanks for the fix, @Postroutine. I made a minor correction to the commented code. Once you've made the change, would you please rebase & squash your commits and then comment here when this PR is ready for another review? |
`category.slug` is not writeable since 648165b.
Handles images with {attach} differently, new feature of Pelican 3.5, current code was not compatible at all as it couldn’t understand where the file was.
…ttp://pillow.readthedocs.io/en/3.1.x/reference/Image.html#PIL.Image.Image.rotate for expand setting - this resizes the image when rotating. It may be applicable to other orientations in this section of code, but I have no photos to test with. See also https://stackoverflow.com/questions/31303938/how-do-i-stop-pil-from-swapping-height-width-when-rotating-an-image-90
Tuple causes error when used, must be list.
Events: New ReadMe file
|
I correct the comment, do a fetch from master and an interactive rebase to push my 2 commits as last commits. Hope I doing it correctly. |
|
@justinmayer: Any news? I am wait the merging of this PR before rebase my other PR. |
|
@justinmayer: Any news? |
ghost
mentioned this pull request
|
Hi @Postroutine. As you can see in this pull request, there are a number of changes that ostensibly are unrelated to your intended changes. Do you see what I mean? |
|
Sincerely, no. Did I miss somthing? |
7 participants
If you enable the "Events" plugin and make your website with the commande
make htmlormake publish, you get an error message:CRITICAL: FileNotFoundError: [Errno 2] Aucun fichier ou dossier de ce type: '…/output/calendar.ics'This PR fix this problem.