Merged
Conversation
8f10e02 to
db40595
Compare
db40595 to
e34a4bc
Compare
8179cc3 to
e4bc27c
Compare
4e3e15a to
32e7100
Compare
56ce3e4 to
532d2cd
Compare
532d2cd to
08076f7
Compare
Contributor
Author
|
I need to update installation documentation accordingly to this before putting it in review. |
08076f7 to
d05d641
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.shwizard that prompts for configuration, auto-generates secrets, and writes.envcompose.ymlusing Docker Compose profiles (letsencrypt/custom-certs,internal-db)versions.envsogit pullupdates them automaticallyscripts/update.shwith auto-detection of existing setup for transparent migration from the old formatscripts/preflight.shto validate system requirements and configuration before launchInstallation (new)
Update (new)
Breaking changes
compose.custom_certs.yml,compose.external_postgres.yml,compose.custom_certs_external_postgres.yml, andcompose.with_postgres_migration.ymlare removedcompose.ymlnow requiresCOMPOSE_PROFILESin.env(set automatically byinstall.shorscripts/update.sh)CERTIFICATE_EMAILremoved (no longer used by Let's Encrypt)depends_on: required: false)Migration for existing users
Run
./scripts/update.shinstead of the old manual update flow. On first run, it auto-detects the previous setup (TLS method + database type), shows the detected profile, and asks for confirmation before writingCOMPOSE_PROFILESto.env.Test plan
./install.shwith Let's Encrypt + internal DB + entire instance on self hosted GitLab./install.shwith Let's Encrypt + internal DB + group organization ongitlab.com./install.shwith custom certs + external DBlocalhostinstall./scripts/preflight.shcatches missing Docker, wrong version, unavailable portsdocker compose configvalidates with all 4 profile combinationscompose.local.ymlstill works for local development.envformat via./scripts/update.sh(verify auto-detection)Note
Medium Risk
Changes the primary installation and deployment configuration (compose structure, required env vars, and update/migration flow), which can break existing self-managed setups if profiles/variables are misdetected or missing.
Overview
Simplifies self-managed installation by adding an interactive
install.shthat runs preflight checks, prompts for GitLab/OIDC + deployment choices, generates secrets, writes.env, and optionally starts the stack.Consolidates production Docker Compose into a single
compose.ymlusingCOMPOSE_PROFILES(letsencryptvscustom-certs, optionalinternal-db), updatescompose.local.ymlto use defaults/explicit localhost URLs, and removes the old split compose files.Adds
scripts/preflight.shandscripts/update.sh(including migration that auto-detects missingCOMPOSE_PROFILES), introduces git-trackedversions.envfor image tags, updates.envexamples/README install instructions, and bumps Helm chart/app versions plus backend/worker image tags tov2.36.5.Written by Cursor Bugbot for commit d05d641. Configure here.