Skip to content

Conversation

@jarnfast
Copy link
Contributor

Porter now passes and handles log levels for plugins in a different way. This means that the messages would be present even when verbosity is set to info - which can garble the data when requesting to show the output as everything is sent to stdout.

Introduced in porter 1.2.0

Behavior in porter <1.2.0:

$ porter installations output show my_output -i my-bundle
data-from-output

Behavior in porter >1.2.0

$ porter installations output show my_output -i my-bundle
NewPlugin.Config.Namespace: porter-system
Store.connect: pre-clientset namespace : porter-system
Store.connect: post-clientset namespace : porter-system
data-from-output

This extra messages can be hidden by setting verbosity to error or warn but I think a better behavior is to hide them in the normal use case (ie. with verbosity set to info).

Behavior after my changes with porter >1.2.0:

$ porter installations output show my_output -i my-bundle
data-from-output

$ porter installations output show my_output -i my-bundle --verbosity debug
<snipped>
NewPlugin.Config.Namespace: porter-system
using plugin
plugin address
Store.connect: pre-clientset namespace : porter-system
Store.connect: post-clientset namespace : porter-system
Store.Resolve: ns:porter-system, keyName:secret, keyValue:01JHJ2KQ2QQQ0KQ4DJ75X75D2P-my_output
data-from-output

Porter now passes and handles log levels for plugins in a different way.
This means that the messages would be present even when verbosity is set
to `info` - which can garble the data when requesting to show the
output.

Signed-off-by: Jens Arnfast <jens@arnfast.net>
Copy link
Contributor

@kichristensen kichristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
I agree with you, it makes sense to change the level of the log message.

@schristoff schristoff merged commit 416adb9 into getporter:main Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants