Skip to content

Add GOVERNANCE file#1284

Merged
carolynvs merged 3 commits intogetporter:mainfrom
carolynvs:governance
Sep 23, 2020
Merged

Add GOVERNANCE file#1284
carolynvs merged 3 commits intogetporter:mainfrom
carolynvs:governance

Conversation

@carolynvs
Copy link
Copy Markdown
Member

What does this change

This explains how the project governs itself today without attempting to introduce any language that we didn't already have existing. Over time we can iterate and improve upon it in follow-on pull requests. I want to get this in without modifying our existing goverance for our inclusion into the CNCF.

What issue does it fix

Closes #1256

Notes for the reviewer

N/A

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

This explains how the project governs itself today without attempting to
introduce any language that we didn't already have existing. Over time
we can iterate and improve upon it in follow-on pull requests. I want to
get this in without modifying our existing goverance for our inclusion
into the CNCF.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Copy link
Copy Markdown
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor notes; otherwise LGTM!

Comment thread GOVERNANCE.md Outdated
Comment thread GOVERNANCE.md Outdated
* Fix typo
* Link to sandbox

Co-authored-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Copy link
Copy Markdown
Contributor

@dev-drprasad dev-drprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread GOVERNANCE.md Outdated
* Maintainer
* Admin

The [OWNERS] defines the current maintainers of the project.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OWNERS file?

Comment thread GOVERNANCE.md

## Roles

We have a [Contribution Ladder] that explains the capabilities and
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere here should say explicitly that the contributor ladder includes the steps to progress to different roles (in other words, that this is the place to find out how to become a maintainer).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now this makes it sound like the contribution ladder file just explains what the different roles and responsibilities are.

Copy link
Copy Markdown
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did add some comments but not required updates.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Copy link
Copy Markdown
Member Author

Thanks @iennae I've incorporated your feedback into the PR. I will merge as soon as I have Jeremy's 👍. After that we can improve as we go in follow-on PRs.

Apologies for the speed, just trying to put a bow on the CNCF transition stuff.

Copy link
Copy Markdown
Contributor

@jeremyrickard jeremyrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, Looks Good.

/lgtm

@carolynvs carolynvs merged commit adbdd36 into getporter:main Sep 23, 2020
@carolynvs carolynvs deleted the governance branch September 23, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create GOVERNANCE file

5 participants