Skip to content

Add logo page#1319

Merged
carolynvs merged 2 commits intogetporter:mainfrom
carolynvs:logo-page
Oct 15, 2020
Merged

Add logo page#1319
carolynvs merged 2 commits intogetporter:mainfrom
carolynvs:logo-page

Conversation

@carolynvs
Copy link
Copy Markdown
Member

What does this change

Add a page that explains our logo and how to use it

What issue does it fix

N/A

Notes for the reviewer

N/A

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

@carolynvs carolynvs requested a review from iennae October 7, 2020 21:52
@carolynvs carolynvs force-pushed the logo-page branch 2 times, most recently from 8b0e48f to 75b6309 Compare October 7, 2020 22:00
@carolynvs carolynvs requested a review from flynnduism October 7, 2020 22:00
Comment thread docs/content/logo.md
Since Michelle helped welcome and inspire so many of us to work with bundles, we
wanted to honor her work getting this ecosystem started by naming our friendly
Porter Cat after her.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the inclusion of this story.

Comment thread docs/content/logo.md
**Simple Shape**

The character should have just enough detail to make them out. The smaller they
get, the less detail they can have to avoid crowding. The attributes
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The smaller they get, the less detail they can have" needs some word smithing. Avoid crowding the image by limiting the details as you make the logo smaller.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm transcribing the text from the images above so that people can read them and make them accessible. For this iteration, is it okay if we go with the original text and later we can work with Ronan to change it? I don't have access to the originals to make the text match if we change the text on the page and it will then be out-of-sync with the picture.

Comment thread docs/content/logo.md
The character should have just enough detail to make them out. The smaller they
get, the less detail they can have to avoid crowding. The attributes
should be prioritized by number rank. A smaller porter cat should have ears and
a hat. Torso could be omitted.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cat's torso can be omitted.

Comment thread docs/content/logo.md
Copy link
Copy Markdown
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, although there are a few areas where I've added a few possible replacements/additions.

Add a page that explains our logo and how to use it

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs merged commit 1f32693 into getporter:main Oct 15, 2020
@carolynvs carolynvs deleted the logo-page branch October 15, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants