Skip to content

docs: move links, add project clarification#1339

Merged
carolynvs merged 1 commit intogetporter:mainfrom
naomi-lgbt:docs/1031/good-first-issue
Oct 23, 2020
Merged

docs: move links, add project clarification#1339
carolynvs merged 1 commit intogetporter:mainfrom
naomi-lgbt:docs/1031/good-first-issue

Conversation

@naomi-lgbt
Copy link
Copy Markdown
Contributor

Signed-off-by: nhcarrigan nhcarrigan@gmail.com

What does this change

Give a summary of the change, and how it affects end-users. It's okay to copy/paste your commit messages.

For example if it introduces a new command or modifies a commands output, give an example of you running the command and showing real output here.

  • Moves the links for the good first issue and help wanted labels from the first paragraph to the bullet list below.
  • Adds a statement to the first paragraph that clarifies the global scope of the project board.

What issue does it fix

Closes #1031

If there is not an existing issue, please make sure we have context on why this change is needed. See our Contributing Guide for examples of when an existing issue isn't necessary.

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
Copy link
Copy Markdown
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making our contributing guide better! 💖

@carolynvs
Copy link
Copy Markdown
Member

/azp run porter

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs
Copy link
Copy Markdown
Member

There was a slight hiccup with the build not reporting its status properly back to GitHub. The build passed though, so I'm merging even though it doesn't show up as completed here in the pull request.

@carolynvs carolynvs merged commit 3ce0bef into getporter:main Oct 23, 2020
@naomi-lgbt naomi-lgbt deleted the docs/1031/good-first-issue branch October 23, 2020 15:20
@carolynvs
Copy link
Copy Markdown
Member

@nhcarrigan Since we aren't using a github app to help us list all of our contributors, would you like to submit a PR to add your name to https://github.com/getporter/porter/blob/main/CONTRIBUTORS.md? Or if you are okay with it, I can add you myself.

@naomi-lgbt
Copy link
Copy Markdown
Contributor Author

Sure I can submit the PR momentarily 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation issue with good first issues on CONTRIBUTING

2 participants