Skip to content

Doc mage#1372

Merged
carolynvs merged 3 commits intogetporter:mainfrom
carolynvs:doc-mage
Nov 23, 2020
Merged

Doc mage#1372
carolynvs merged 3 commits intogetporter:mainfrom
carolynvs:doc-mage

Conversation

@carolynvs
Copy link
Copy Markdown
Member

What does this change

  • How to install
  • Bash completions
  • Targets

What issue does it fix

Follow-up to #1321

Notes for the reviewer

N/A

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

@carolynvs carolynvs marked this pull request as ready for review November 19, 2020 21:56
Copy link
Copy Markdown
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hit a hiccup w/ the mage completion, otherwise looks great.

Comment thread CONTRIBUTING.md Outdated
Comment thread scripts/mage-completion.sh
* How to install
* Bash completions
* Targets

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Explain how to install bash completion, which is used by mage.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Copy link
Copy Markdown
Member Author

@vdice Okay I've documented that bash-completion is required for autocomplete with mage to work.

@carolynvs carolynvs merged commit 62d8d14 into getporter:main Nov 23, 2020
@carolynvs carolynvs deleted the doc-mage branch November 23, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants