Rearrange dependencies syntax to be nested in 'requires' object#1573
Rearrange dependencies syntax to be nested in 'requires' object#1573carolynvs merged 6 commits intogetporter:v1from
Conversation
Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>
Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>
|
Just a heads up that I'm "retargeting" your pull request against the brand new v1 branch. We are isolating the changes for v1 in a separate branch to avoid repeatedly breaking things for people. More details in this PR: #1574 |
carolynvs
left a comment
There was a problem hiding this comment.
Sweet! This is nearly there. You should do a sweep for any other porter.yaml files that have dependencies in it. That is why the one test is failing but we want to make sure that we find all of them.
Here is the one causing the test to fail: https://github.com/getporter/porter/blob/main/build/testdata/bundles/wordpress/porter.yaml
Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>
Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>
|
remains the broken test |
|
The test is failing because you missed a few porter.yaml files in the repository. Do a find for the word After you update them (some are in documentation, others are test files), the test will pass. Here are a couple that I found but there may be more:
After you get the tests passing, the last change requires is updating the schema file used by porter in the |
Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>
Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>
|
/azp run porter-integration |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
carolynvs
left a comment
There was a problem hiding this comment.
Thank you for tackling this larger change!
What does this change
This PR embeds dependencies in an
requiresobject (porter.yaml).What issue does it fix
Closes #1570
Notes for the reviewer
pkg/porter/install_test.gorelies on test data which is pre-populated in the repo. At this point, I was not sure how test data has been generated and if I can replace it. Would be great to chat about thatChecklist