Skip to content

Only pull sometimes#1734

Closed
carolynvs wants to merge 1 commit intogetporter:release/v1from
carolynvs:only-pull-sometimes
Closed

Only pull sometimes#1734
carolynvs wants to merge 1 commit intogetporter:release/v1from
carolynvs:only-pull-sometimes

Conversation

@carolynvs
Copy link
Member

@carolynvs carolynvs commented Aug 24, 2021

Fixes a regression introduced in #1723. I missed that we shouldn't try to pull the invocation image to retrieve the repository digests unless the bundle has a repository digest defined in the bundle definition (which indicates that it has been published and is "pullable"). We still want to allow people developing locally to be able to run build then install without having ever published.

This showed up only in the integration tests:

dependencies_test.go:81: 
        	Error Trace:	dependencies_test.go:81
        	            				dependencies_test.go:27
        	Error:      	Received unexpected error:
        	            	1 error occurred:
        	            		* Error response from daemon: manifest for localhost:5000/wordpress-installer:v0.1.4 not found: manifest unknown: manifest unknown
        	            	
        	Test:       	TestDependenciesLifecycle
        	Messages:   	install of root bundle failed

Do not try to pull an image that hasn't been pulled. This occurs when we
are running a bundle locally and haven't pushed it somewhere yet.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs changed the base branch from main to release/v1 August 24, 2021 14:03
@carolynvs carolynvs force-pushed the only-pull-sometimes branch from 81cd016 to f0abf05 Compare August 24, 2021 14:06
@carolynvs
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs
Copy link
Member Author

I've realized in this PR that when the tests run together (instead of you just running a single test at a time), that the pull behavior of Porter is different. Running the test singly results in Porter not trying to pull the bundle. But running the entire integration test suite at once results in a pull when it shouldn't occur.

I'm going to pause working on this PR for a bit until after KubeCon and then figure that out.

@carolynvs
Copy link
Member Author

I'll try again later, closing.

@carolynvs carolynvs closed this Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant