Closed
Conversation
Do not try to pull an image that hasn't been pulled. This occurs when we are running a bundle locally and haven't pushed it somewhere yet. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
81cd016 to
f0abf05
Compare
Member
Author
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
I've realized in this PR that when the tests run together (instead of you just running a single test at a time), that the pull behavior of Porter is different. Running the test singly results in Porter not trying to pull the bundle. But running the entire integration test suite at once results in a pull when it shouldn't occur. I'm going to pause working on this PR for a bit until after KubeCon and then figure that out. |
Member
Author
|
I'll try again later, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #1723. I missed that we shouldn't try to pull the invocation image to retrieve the repository digests unless the bundle has a repository digest defined in the bundle definition (which indicates that it has been published and is "pullable"). We still want to allow people developing locally to be able to run build then install without having ever published.
This showed up only in the integration tests: