Merged
Conversation
Document how to specify multiple values. close MChorfa/porter-helm3#24
MChorfa
requested review from
carolynvs,
jeremyrickard and
vdice
as code owners
Member
|
@MChorfa can you add your signature to the commit message so that the DCO check to pass? |
Document how to specify multiple values. close MChorfa/porter-helm3#24 Signed-off-by: Mohamed Chorfa <chorfa672@gmail.com>
MChorfa
force-pushed
the
patch-1
branch
2 times, most recently
from
d5a9358 to
13a8ff9
Compare
* 'patch-1' of ssh://github.com/MChorfa/porter: Update helm3 mixin doc Signed-off-by: Mohamed Chorfa <chorfa672@gmail.com>
Contributor
Author
|
DCO is refusing to go through no matter how I sign |
Member
|
The problem is on this commit 2f46fb9. It is missing the "signed-off by" line at the end of the message. |
Member
|
If you are having trouble with git, just comment here that's it's okay for me to squash your 3 commits and use your signoff on the other commits as signoff for the entire PR. |
Contributor
Author
|
Yes, please, signing off the commits . For the next time, I will have my machine set up correctly. sorry :( |
Member
|
No worries, I mess up the DCO pretty regularly and it takes a bit of effort with git to fix it. Thank you for the updated docs! 💖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document how to specify multiple values.
What issue does it fix
Closes MChorfa/porter-helm3#24
Checklist