Include schemaType when exporting resource documents#1805
Merged
carolynvs merged 1 commit intogetporter:release/v1from Oct 18, 2021
Merged
Include schemaType when exporting resource documents#1805carolynvs merged 1 commit intogetporter:release/v1from
carolynvs merged 1 commit intogetporter:release/v1from
Conversation
When we export a resource, like porter installation show, include a schemaType field that indicates the resource type: Installation, CredentialSet or ParameterSet. This field isn't used by Porter, but helps editors determine the schema of the document. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
schema-version2
branch
from
d6cf2a3 to
495c861
Compare
vdice
approved these changes
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
When we export a resource, like porter installation show, include a schemaType field that indicates the resource type: Installation, CredentialSet or ParameterSet. This field isn't used by Porter, but helps editors determine the schema of the document.
Since this is a new optional field (that is not stored in the database) it is not a breaking change.
What issue does it fix
Closes #1799
Notes for the reviewer
I also tweaked how we store documents to ensure that the schema version is always set.
Checklist