pkg/config: fix Telemetry struct tag#1863
Merged
carolynvs merged 1 commit intogetporter:release/v1from Jan 18, 2022
Merged
Conversation
VinozzZ
requested review from
carolynvs,
jeremyrickard and
vdice
as code owners
This PR adds missing double quotes for Telemetry struct tag so it can be properly set if present. Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
carolynvs
approved these changes
Jan 18, 2022
Member
carolynvs
left a comment
carolynvs
left a comment
There was a problem hiding this comment.
I'm so glad you noticed that, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
This PR adds missing double quotes for Telemetry struct tag so it can be
properly set if present.
What issue does it fix
Part of #1857
Notes for the reviewer
Put any questions or notes for the reviewer here.
Checklist
Reviewer Checklist