Skip to content

Use v1 contributing info on main porter site#2173

Merged
carolynvs merged 1 commit intogetporter:mainfrom
carolynvs:contribute-to-v1
Jun 20, 2022
Merged

Use v1 contributing info on main porter site#2173
carolynvs merged 1 commit intogetporter:mainfrom
carolynvs:contribute-to-v1

Conversation

@carolynvs
Copy link
Member

@carolynvs carolynvs commented Jun 19, 2022

What does this change

Now that all new development should be against the release/v1 branch, I've updated the contributing tutorial on the main branch to instruct people to work with release/v1 and use the udpated v1 instructions.

We have been getting a number of confused contributors because they come to the contributing tutorial from the main site which is for our main branch and this should help get them the correct info to contribute.

Here is a preview of the updated contributing tutorial https://deploy-preview-2173--porter.netlify.app/contribute/tutorial/

What issue does it fix

Closes #2172

Notes for the reviewer

I will open a follow-up PR to the v1 branch with some of the other tweaks I made to the contributing tutorial so that they are both up-to-date.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Now that all new development should be against the release/v1 branch,
I've updated the contributing tutorial on the main branch to instruct
people to work with release/v1 and use the udpated v1 instructions.

We have been getting a number of confused contributors because they come
to the contributing tutorial from the main site which is for our main
branch and this should help get them the correct info to contribute.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs requested a review from VinozzZ June 19, 2022 00:24
@carolynvs carolynvs marked this pull request as ready for review June 20, 2022 13:45
@carolynvs carolynvs merged commit b7bc1d3 into getporter:main Jun 20, 2022
@carolynvs carolynvs deleted the contribute-to-v1 branch June 20, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiling from source with a M1 MacBook Pro while following the documentation fails

1 participant