Prepare canary builds for publishing#2409
Merged
carolynvs merged 1 commit intogetporter:mainfrom Oct 10, 2022
Merged
Conversation
When we cross-compile porter or the mixins (anything really), some of Porter's common publishing code (such as the atom.xml feed generator), expects that the canary build will be in bin/canary (or bin/mixins/exec/canary). When I migrated this part of publishing from make to mage on the release/v1 branch, I missed prepping the build for publish and never noticed because we weren't publishing canary builds of porter from the release/v1 branch. Now that we are on main again, the canary publish was failing because we had a dev directory and a versioned directory (e.g. v1.0.0-gblah) but no canary. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Member
Author
|
/azp run test-porter-release |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we cross-compile porter or the mixins (anything really), some of Porter's common publishing code (such as the atom.xml feed generator), expects that the canary build will be in bin/canary (or bin/mixins/exec/canary).
When I migrated this part of publishing from make to mage on the release/v1 branch, I missed prepping the build for publish and never noticed because we weren't publishing canary builds of porter from the release/v1 branch. Now that we are on main again, the canary publish was failing because we had a dev directory and a versioned directory (e.g. v1.0.0-gblah) but no canary.
Fixes #2406