Skip to content

Fix canary script#2414

Merged
carolynvs merged 2 commits intogetporter:mainfrom
carolynvs:fix-canary-script
Oct 11, 2022
Merged

Fix canary script#2414
carolynvs merged 2 commits intogetporter:mainfrom
carolynvs:fix-canary-script

Conversation

@carolynvs
Copy link
Member

@carolynvs carolynvs commented Oct 11, 2022

What does this change

Use permalink in install scripts for canary

When we upload an installation script to our github releases page for a release, the script is rewritten to include the version of porter to install. When it's a tagged release that works fine, but at the moment it's embedding the version number even when it's not a release, namely the canary build. Canary binaries are not uploaded under v1.0.0-gsomehash, and instead go into a release named "canary".

I've updated the build scripts so that when we upload the fixed install script for a canary release, the permalink "canary" is replaced in the install script instead of the git describe generated version number.

Do not call list when installing porter

Just call version to validate we installed the binaries properly. Don't call list since only the linux agent has docker installed.

What issue does it fix

Closes #2387

Notes for the reviewer

N/A

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

When we upload an installation script to our github releases page for a release, the script is rewritten to include the version of porter to install. When it's a tagged release that works fine, but at the moment it's embedding the version number even when it's not a release, namely the canary build. Canary binaries are not uploaded under v1.0.0-gsomehash, and instead go into a release named "canary".

I've updated the build scripts so that when we upload the fixed install script for a canary release, the permalink "canary" is replaced in the install script instead of the git describe generated version number.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Just call version to validate we installed the binaries properly. Don't call list since only the linux agent has that installed.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs marked this pull request as ready for review October 11, 2022 15:20
@carolynvs carolynvs merged commit 0dc5f62 into getporter:main Oct 11, 2022
@carolynvs carolynvs deleted the fix-canary-script branch October 11, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Canary script has wrong download link

1 participant