Conversation
When we upload an installation script to our github releases page for a release, the script is rewritten to include the version of porter to install. When it's a tagged release that works fine, but at the moment it's embedding the version number even when it's not a release, namely the canary build. Canary binaries are not uploaded under v1.0.0-gsomehash, and instead go into a release named "canary". I've updated the build scripts so that when we upload the fixed install script for a canary release, the permalink "canary" is replaced in the install script instead of the git describe generated version number. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Just call version to validate we installed the binaries properly. Don't call list since only the linux agent has that installed. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
Use permalink in install scripts for canary
When we upload an installation script to our github releases page for a release, the script is rewritten to include the version of porter to install. When it's a tagged release that works fine, but at the moment it's embedding the version number even when it's not a release, namely the canary build. Canary binaries are not uploaded under v1.0.0-gsomehash, and instead go into a release named "canary".
I've updated the build scripts so that when we upload the fixed install script for a canary release, the permalink "canary" is replaced in the install script instead of the git describe generated version number.
Do not call list when installing porter
Just call version to validate we installed the binaries properly. Don't call list since only the linux agent has docker installed.
What issue does it fix
Closes #2387
Notes for the reviewer
N/A
Checklist
Reviewer Checklist