Skip to content

Remove makefile#2416

Merged
carolynvs merged 1 commit intogetporter:mainfrom
carolynvs:remove-makefile
Oct 11, 2022
Merged

Remove makefile#2416
carolynvs merged 1 commit intogetporter:mainfrom
carolynvs:remove-makefile

Conversation

@carolynvs
Copy link
Member

What does this change

I have moved the last target, setup-dco, over to mage and removed our Makefile.

SetupDCO will only work on shells that support bash (because the git commit hook is written in bash). Our mage target attempts to detect if running in cmd/powershell and warns the user.

What issue does it fix

No more confusing makefile + magefile.go in our repo! 🎉

Notes for the reviewer

N/A

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

I have moved the last target, setup-dco, over to mage and removed our Makefile.

SetupDCO will only work on shells that support bash (because the git commit hook is written in bash). Our mage target attempts to detect if running in cmd/powershell and warns the user.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs
Copy link
Member Author

/azp run test-porter-release

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs carolynvs marked this pull request as ready for review October 11, 2022 15:46
@carolynvs carolynvs merged commit 9804cb1 into getporter:main Oct 11, 2022
@carolynvs carolynvs deleted the remove-makefile branch October 11, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant