Default bundles to schemaVersion 1.0.1#2583
Merged
carolynvs merged 1 commit intogetporter:mainfrom Feb 21, 2023
Merged
Conversation
* Bump the default version of bundles created with `porter create` to 1.0.1 with the schemaType set. * Fix the allowed schema versions for bundle manifests, it wasn't including 1.0.1 * Fix documentation for which version of Porter supports manifest schemaVersion 1.0.1 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
fix-manifest-schemaVersion
branch
from
9ced54f to
dc03f14
Compare
sgettys
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
Bump the default version of bundles created with
porter createto 1.0.1 with the schemaType set.Because I forgot to update
manifest.SupportedSchemaVersionsin #2428 this means that people can't use Bundle schemaVersion 1.0.1 as documented in 1.0.8 and it's really available in 1.0.9 (to be released after this is merged). They can still set schemaType, and porter build doesn't fail, so it did fix the original bug. It's just that if the user bumps the schemaVersion on their porter.yaml porter build will then fail validation. Sorry that's pretty sloppy... 🤦♀️What issue does it fix
Follow-up to #2428
Notes for the reviewer
N/A
Checklist
Reviewer Checklist