Param sets override persisted --param values on upgrade

[kichristensen]

What does this change

When running porter upgrade with a parameter set, Porter was ignoring
the parameter set values for any parameter that had been previously set
via --param in an earlier invocation. The old persisted value would
silently win, making it impossible to update a parameter's value by
switching to a parameter set.

The fix corrects the precedence order so that:

1. Current --param CLI flags win over everything
2. Named parameter set values win over old persisted values
3. Old persisted values are used only as a fallback when neither a CLI flag nor a parameter set provides a value

The same precedence is applied in the porter apply (reconcile) path: parameters specified inline in the installation YAML are treated as current overrides and win over parameter sets.

What issue does it fix

Closes #3599

Notes for the reviewer

Root cause was in applyActionOptionsToInstallation (pkg/porter/parameters.go):

1. loadParameterSets() received inst.Parameters.Parameters (all persisted params from previous runs) as its overridenParameters argument, causing it to skip resolving parameter set values for any param that had ever been set via --param.
2. The subsequent merge loop applied all resolvedOverrides (resolved inst.Parameters) on top of parameter set values, so old persisted values always won.

The fix builds cliOverridesList containing only params from the current invocation's --param flags (step 3), and changes the merge loop (step 5) to only let resolvedOverrides win when the key is a current CLI override or not already provided by a parameter set.

For the porter apply path, ReconcileInstallation now sets CurrentParamOverrides on BundleExecutionOptions directly (a secrets.StrategyList) instead of serializing inline params to name=value strings. This avoids a string round-trip through ParseVariableAssignments that would have (a) skipped sanitized SourceSecret params on subsequent reconciles, (b) silently stripped leading/trailing whitespace from values, and (c) re-injected params removed from the bundle definition.

Checklist

• Did you write tests?
• Did you write documentation?
• Did you change porter.yaml or a storage document record? Update the corresponding schema file.
• If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

[Copilot]

Pull request overview

Fixes a parameter-resolution precedence bug where named parameter sets on porter upgrade were silently ignored for any parameter that had previously been set via --param. The fix distinguishes "current invocation overrides" (CLI --param flags and inline YAML params from the apply path) from "old persisted values" so that parameter sets correctly take precedence over the latter.

Changes:

• In applyActionOptionsToInstallation, build cliOverridesList containing only current-invocation overrides (passed to loadParameterSets), and update the final merge loop so old persisted values only fill gaps not covered by a parameter set.
• Add CurrentParamOverrides secrets.StrategyList to BundleExecutionOptions, and have ReconcileInstallation populate it with opts.Installation.Parameters.Parameters instead of round-tripping through string serialization.
• Add a unit regression test plus two integration tests (with a small new test bundle) covering: param set overrides previous --param, and --param overrides param set.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/porter/parameters.go	Reworks parameter set resolution and final merge to distinguish current overrides from old persisted values.
pkg/porter/lifecycle.go	Adds CurrentParamOverrides field to BundleExecutionOptions.
pkg/porter/reconcile.go	Passes inline YAML installation parameters through CurrentParamOverrides instead of serializing them.
pkg/porter/lifecycle_test.go	Unit regression test for the precedence fix.
tests/integration/upgrade_test.go	Integration tests covering both precedence directions.
tests/integration/testdata/bundles/bundle-with-param-set-upgrade/porter.yaml	New tiny test bundle echoing the name parameter for the integration tests.
tests/integration/testdata/bundles/bundle-with-param-set-upgrade/helpers.sh	Helper script invoked by the test bundle.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.