Add migration to deduplicate connectors and enforce uniqueness#1041
Merged
SachaProbo merged 1 commit intomainfrom Apr 20, 2026
Merged
Add migration to deduplicate connectors and enforce uniqueness#1041SachaProbo merged 1 commit intomainfrom
SachaProbo merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/coredata/migrations/20260414T125046Z.sql">
<violation number="1" location="pkg/coredata/migrations/20260414T125046Z.sql:18">
P1: Re-link dependent `access_sources` rows before deleting duplicate connectors, otherwise the FK can make this migration fail.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
e444f71 to
1ddb19a
Compare
Delete duplicate connectors per (organization_id, provider), keeping the oldest one, then add a unique index to prevent future duplicates. Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
1ddb19a to
c32aff5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete duplicate connectors per (organization_id, provider), keeping the oldest one, then add a unique index to prevent future duplicates.
Summary by cubic
Deduplicates connectors per organization and provider by keeping the oldest. Adds a unique index to enforce one connector per pair going forward.
access_sources.connector_idFK to ON DELETE CASCADE, delete newer duplicates (keep oldest bycreated_at), then restore the FK.idx_connectors_organization_id_provideron(organization_id, provider); run during a low-write window due to locks.Written for commit c32aff5. Summary will update on new commits.