Prevent duplicate active document versions#1046
Merged
SachaProbo merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/coredata/migrations/20260414T120000Z.sql">
<violation number="1" location="pkg/coredata/migrations/20260414T120000Z.sql:17">
P1: This unique index can fail migration on existing data because it adds a new cross-status uniqueness rule without first deduplicating active versions.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
SachaProbo
force-pushed
the
SachaProbo/dup-pending-versions
branch
5 times, most recently
from
efe9938 to
b40c0aa
Compare
SachaProbo
force-pushed
the
SachaProbo/dup-pending-versions
branch
2 times, most recently
from
f70d635 to
9e57b44
Compare
Replace the draft-only unique index with one covering both DRAFT and PENDING_APPROVAL statuses, ensuring a document can have at most one active version at a time. Deduplicate any existing data before creating the index, prioritizing PENDING_APPROVAL over DRAFT. Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
SachaProbo
force-pushed
the
SachaProbo/dup-pending-versions
branch
from
9e57b44 to
0b9686f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the draft-only unique index with one covering both DRAFT and PENDING_APPROVAL statuses, ensuring a document can have at most one active version at a time.
Summary by cubic
Prevents multiple active versions (DRAFT or PENDING_APPROVAL) per document by enforcing the unique partial index
document_one_active_version_idx. Violations now returnErrResourceAlreadyExists.document_one_draft_version_idxand createsdocument_one_active_version_idxondocument_versions (document_id)for DRAFT/PENDING_APPROVAL.Written for commit 0b9686f. Summary will update on new commits.