Cookie banner uncategorised category

[codenem]

Closes ENG-302

---

Summary by cubic

Adds an Uncategorised cookie category and replaces the required flag with a kind enum to simplify consent logic, category management, and UI. Also adds an atomic moveCookieToCategory mutation and improves delete flows with confirmation and clearer error handling.

• New Features

  • Switched from required to kind (NORMAL, NECESSARY, UNCATEGORISED) across backend, GraphQL, and packages/cookie-banner.
  • Added a single UNCATEGORISED category per banner. Deleting a NORMAL category moves its cookies there. NECESSARY and UNCATEGORISED are undeletable; NECESSARY is always on.
  • New GraphQL mutation moveCookieToCategory for atomic cookie moves. Console adds a per-cookie “Move to” dropdown, delete confirmations with clear messaging, and toasts that surface server errors; badges/buttons reflect kind. Edit/add forms were extracted into components for a cleaner cookie editor.
  • Documented a React guideline to avoid destructuring unused values and removed an unused destructured variable.

• Migration

  • Run pkg/coredata/migrations/20260420T143027Z.sql to add kind, backfill from required, drop required, and enforce one NECESSARY and one UNCATEGORISED per banner.
  • Update GraphQL usage: CookieCategory.required → kind; remove required from CreateCookieCategoryInput. Use moveCookieToCategory instead of two updateCookieCategory calls when moving cookies.
  • Update web components and client: probo-category now uses a kind attribute; consent defaults in packages/cookie-banner depend on kind === "NECESSARY".

^{Written for commit 9848795. Summary will update on new commits.}

[cubic-dev-ai]

3 issues found across 19 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/console/src/pages/organizations/cookie-banners/configuration/cookies/_components/CategorySection.tsx">

<violation number="1" location="apps/console/src/pages/organizations/cookie-banners/configuration/cookies/_components/CategorySection.tsx:271">
P1: Moving a cookie is implemented as two non-atomic updates, so a partial failure can duplicate the cookie across categories.</violation>
</file>

<file name="pkg/coredata/cookie_banner_version.go">

<violation number="1" location="pkg/coredata/cookie_banner_version.go:42">
P1: This snapshot schema change is not backward-compatible with existing stored version JSON (`required`), so legacy snapshots deserialize with an empty `kind` and can lose necessary-category semantics.</violation>
</file>

<file name="pkg/cookiebanner/service.go">

<violation number="1" location="pkg/cookiebanner/service.go:973">
P2: Uncategorised is only auto-created when the deleted category has cookies, so banners missing that system category can stay invalid after deleting empty categories.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

4 issues found across 8 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/console/src/pages/organizations/cookie-banners/configuration/cookies/_components/EditCookieRow.tsx">

<violation number="1" location="apps/console/src/pages/organizations/cookie-banners/configuration/cookies/_components/EditCookieRow.tsx:35">
P2: Don't initialize editable state once from props here. With index keys in the parent, the row can be reused for a different cookie while keeping stale form values, so Save may write the wrong data.</violation>
</file>

<file name="pkg/cookiebanner/service.go">

<violation number="1" location="pkg/cookiebanner/service.go:951">
P1: Reject moves where source and target category are identical; currently this duplicates the cookie when both IDs are the same.</violation>
</file>

<file name="pkg/server/api/console/v1/graphql/cookie_banner.graphql">

<violation number="1" location="pkg/server/api/console/v1/graphql/cookie_banner.graphql:245">
P1: Reject source==target here; a self-move can duplicate the cookie.</violation>

<violation number="2" location="pkg/server/api/console/v1/graphql/cookie_banner.graphql:247">
P2: Use a stable cookie identifier instead of the name; name-only lookup is ambiguous.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

1 issue found across 3 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="pkg/server/api/console/v1/cookie_banner_resolvers.go">

<violation number="1" location="pkg/server/api/console/v1/cookie_banner_resolvers.go:540">
P2: Return a non-NotFound error for banner mismatches; both categories were already found, so this path is an invalid move, not a missing resource.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}