Fix errcheck and ineffassign lint errors#1101
Merged
SachaProbo merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fix lint errors by making cleanup calls
errcheck-safe and removing an unnecessary assignment in the agent loop. This keeps resource cleanup consistent and removes noisy lints.Close/RemoveAlldefers withdefer func() { _ = ... }()inpkg/agent/run.go,pkg/agent/tools/browser/download_pdf.go,pkg/agent/tools/browser/fetch_sitemap.go, andpkg/agent/tools/security/whois.go.emptyOutputRetries = 0assignment incoreLoopto satisfyineffassign(no behavior change).Written for commit ab5654f. Summary will update on new commits.