fix(snapshot-tests): Guard CLI snapshot process output#421
Merged
Conversation
Fail CLI domain snapshot invocations when the CLI process itself fails, is terminated, has no exit status, or emits unexpected stderr. This keeps fixtures focused on domain tool output while preventing hidden process-level noise from being ignored. Co-Authored-By: OpenAI Codex <codex@openai.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard CLI domain snapshot tests against process-level failures and stderr noise.
The snapshot suite is intended to cover domain tool success and failure output, not CLI bootstrap or parser errors. Before this change, the CLI snapshot harness only read stdout, so a snapshot could pass while the actual CLI process failed unusually, was terminated, had no exit status, or emitted stderr that users would see.
This keeps fixture contents focused on stdout domain output while failing fast on process-level conditions that should not be hidden by snapshot normalization.
Also renames the CLI and MCP JSON snapshot entrypoint files so they describe the runtime suites they register, instead of implying fixture parity assertions.