fix: include dist/ directory in source control #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove dist/ from .gitignore as it's required for GitHub Actions - Add explanatory comment about why dist/ must be committed - Rebuild dist/ files to ensure they're up-to-date GitHub Actions require compiled artifacts to be committed since they run directly from the repository without a build step.
- Add explicit section explaining why dist/ must be committed - Clarify that GitHub Actions differ from typical JS/TS projects - Reference action.yml main entry point and check-dist.yml workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dist/from.gitignoreas it's required for GitHub Actionsdist/directorydist/must be committedBackground
GitHub Actions run directly from the repository without a build step, so compiled artifacts must be committed. This differs from typical JavaScript/TypeScript projects where build outputs are ignored.
Test plan
action.ymlpoints todist/index.jsdist/files to ensure they're current